refactor: fix code inspection - collection to array

[zielint0]

Use modern way to convert collection to array.

old: (mSourceClasspath.toArray(new String[mSourceClasspath.size()]));
new: (mSourceClasspath.toArray(new String[0]));

benefits:

• more readable
• faster to understand
• a bit faster

I am ready to merge.

[surli]

Here again I'm ok to merge but I want some more sources: I'm not entirely sure it's more readable as you loose the concept of size of the array. A beginner might think the array will be empty at the end. But ok let's say now everyone knows that the array won't be empty.

What about the performance?
I'd think that as the method doesn't have to compute the size of the array it would be faster when passing an array with the proper size: so why would it be faster this way?

[zielint0]

Performance | 'Collection.toArray()' call style

There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]).
In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation.
This inspection allows to follow the uniform style: either using an empty array (which is recommended in modern Java) or using a pre-sized array (which might be faster in older Java versions or non-HotSpot based JVMs).

[surli]

ok thanks