refactor: remove commented code from tests #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
reviewed
Jul 30, 2018
|
|
||
| // for now the type of CtCatchVariable is not the same | ||
| // this should be fix in the future (see: https://github.com/INRIA/spoon/issues/1420) | ||
| //assertEquals(variable2, variable1); |
There was a problem hiding this comment.
As it looks fixed we should instead uncomment the assertEquals.
There was a problem hiding this comment.
@surli
Thank you for this hint!
I restored an assertion. All tests pass.
zielint0
changed the title
zielint0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like that is is fixed/obsolete
But if it is needed, I will restore it.
@surli
?
I am ready to merge.