-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove commented code (SonarQube defect fix) #2251
Merged
pvojtechovsky
merged 15 commits into
INRIA:master
from
zielint0:refactor-remove-commented-code-from-substitution
Jul 23, 2018
Merged
refactor: remove commented code (SonarQube defect fix) #2251
pvojtechovsky
merged 15 commits into
INRIA:master
from
zielint0:refactor-remove-commented-code-from-substitution
Jul 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@surli |
zielint0
changed the title
refactor: remove commented code from Substitution.java
WIP refactor: remove commented code from Substitution.java
Jul 20, 2018
zielint0
changed the title
WIP refactor: remove commented code from Substitution.java
WIP refactor: remove commented code (SonarQube defect fix)
Jul 20, 2018
zielint0
changed the title
WIP refactor: remove commented code (SonarQube defect fix)
refactor: remove commented code (SonarQube defect fix)
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitution.java
I paid attention not to remove:
CtRolePathElement.java (line 112)
//No element found for name.
Is this commented needed?
I am ready to merge.