Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove commented code (SonarQube defect fix) #2251

Merged
merged 15 commits into from
Jul 23, 2018
Merged

refactor: remove commented code (SonarQube defect fix) #2251

merged 15 commits into from
Jul 23, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Jul 19, 2018

  • PR fixes some SonarQube violations: This block of commented-out lines of code should be removed.
  • Remove not thrown exceptions in test - VariableReferencesTest.java
  • Fix formatting

Substitution.java
I paid attention not to remove:

//if (!f.getSimpleName().equals("_" + f.getAnnotation(Parameter.class).value())) {
//	throw new TemplateException("the field name of a proxy template parameter must be called _" + f.getSimpleName());
//}

CtRolePathElement.java (line 112)
//No element found for name.
Is this commented needed?

I am ready to merge.

@zielint0
Copy link
Contributor Author

@surli
What is pull_request-INRIA-spoon-newtestcheck — [INFO] BUILD SUCCESS and why it happens from time to time? (not always?)

@zielint0 zielint0 changed the title refactor: remove commented code from Substitution.java WIP refactor: remove commented code from Substitution.java Jul 20, 2018
@zielint0 zielint0 changed the title WIP refactor: remove commented code from Substitution.java WIP refactor: remove commented code (SonarQube defect fix) Jul 20, 2018
@zielint0 zielint0 changed the title WIP refactor: remove commented code (SonarQube defect fix) refactor: remove commented code (SonarQube defect fix) Jul 20, 2018
@pvojtechovsky pvojtechovsky merged commit 6be365c into INRIA:master Jul 23, 2018
@monperrus monperrus mentioned this pull request Sep 20, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants