fix: sonarqube remove commented code #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,10 +62,6 @@ public static TobeMatched create(ImmutableMap parameters, ContainerKind containe | |||
| } | |||
|
|
|||
| private TobeMatched(ImmutableMap parameters, Object target) { | |||
| //It is correct to put whole container as single value in cases when ParameterNode matches agains whole attribute value | |||
There was a problem hiding this comment.
keep this comment please. I am OK to remove next commented code
|
This PR is OK for me. Just with exception of one comment mentioned above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarQube rationale
Commented code is always availabe in repository.
There is no need to keep it (waiting for better times).