Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review fix(MavenLauncher): Improving MavenLauncher dependancy resolution #2112

Merged
merged 31 commits into from
Aug 9, 2018
Merged

review fix(MavenLauncher): Improving MavenLauncher dependancy resolution #2112

Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0ead891
add a test for getRoleInParent / getValueByRole consistence
nharrand Feb 21, 2018
819aa1c
fix: MavenLauncher resolve dependancies which version is defined in p…
nharrand Jun 26, 2018
153be0d
Merge branch 'master' of https://github.com/nharrand/spoon
nharrand Jun 26, 2018
95d99d3
Merge branch 'master' of https://github.com/nharrand/spoon
nharrand Jun 26, 2018
991985b
Merge branch 'master' of https://github.com/nharrand/spoon
nharrand Jun 26, 2018
fa60f93
feat(MavenLauncher): MavenLauncher now get its classpath from a maven…
nharrand Jul 12, 2018
8fef644
clean(MavenLauncherTest): remove unused import
nharrand Jul 12, 2018
5e03011
Merge branch 'master' into master
nharrand Jul 12, 2018
5a5c2c6
Update MavenLauncherTest.java
nharrand Jul 12, 2018
c7ed307
POC MavenLauncher implementation with MavenCli
nharrand Jul 12, 2018
9729941
POC MavenLauncher implementation with MavenCli
nharrand Jul 12, 2018
912325d
merge
nharrand Jul 12, 2018
7a956fe
cleanup(MavenLauncherTest)
nharrand Jul 12, 2018
9d74873
refactor(MavenLauncher): use MavenInvoker
nharrand Jul 18, 2018
869d445
merge
nharrand Jul 18, 2018
78b5aab
set up M2_HOME environement variable in travis
nharrand Jul 19, 2018
98a84d9
revert previous travis changes
nharrand Jul 19, 2018
2ae448b
Update .travis.yml
nharrand Jul 19, 2018
1b5aa49
Add headers
nharrand Jul 26, 2018
e7bd6b7
Merge branch 'master' of https://github.com/nharrand/spoon
nharrand Jul 26, 2018
b3427ea
debugging travis script jdk10
nharrand Jul 26, 2018
fb5c7aa
refactoring, update certificate on travis script for java 10
nharrand Jul 26, 2018
eb54db8
stop deleting files before reading them...
nharrand Jul 26, 2018
75fbf98
yet another attempt at fixing travis build with java 10
nharrand Jul 26, 2018
e889890
yet another attempt at fixing travis build with java 10
nharrand Jul 26, 2018
6006a54
switch to multi classpath files
nharrand Aug 1, 2018
2f8f42c
merge and checkstyle fixes
nharrand Aug 1, 2018
54befff
this certificate problem is getting annoying
nharrand Aug 1, 2018
51b9200
fail first
nharrand Aug 1, 2018
e880745
Post review improvements
nharrand Aug 2, 2018
57af73c
fix some exception handeling, add a reflexive test to check that all …
nharrand Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ group: edge
jdk: openjdk8

env:
global:
- M2_HOME="/usr/local/maven"
matrix:
- SCRIPT=travis-jdk9.sh
- SCRIPT=travis-jdk8.sh
- SCRIPT=travis-coverage.sh
Expand Down
4 changes: 3 additions & 1 deletion chore/travis/travis-jdk10.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
chmod +x install-jdk.sh

export JAVA_HOME=$HOME/openjdk8
source ./install-jdk.sh -f 10

# Use the default (the one present in the base container) collection of trusted certificate authority (CA) certificates for java
source ./install-jdk.sh -f 10 -c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why you needed this argument?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! So basically it tells install-jdk.sh to use the default (the one present in the base conatiner) collection of trusted certificate authority (CA) certificates for java. Without this option, calling maven from java results in SSL errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can you add a comment on the script please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


mvn -Djava.src.version=1.10 test
7 changes: 6 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>3.3.9</version>
<version>3.5.0</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down Expand Up @@ -284,6 +284,11 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-invoker</artifactId>
<version>3.0.1</version>
</dependency>
</dependencies>

<build>
Expand Down
Loading