Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature CtScannerListener listens for nodes of EarlyTerminatingScanner #1210

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

@pvojtechovsky pvojtechovsky commented Mar 8, 2017

As discussed in #1180 there is an new contract of EarlyTerminatingScanner. There is possible to register implementation of CtScannerListener, which can be used to listen for entering/exiting of node scanning and which can influence, whether node and child nodes are scanned, by return value of CtScannerListener#enter

There is no test. It will be indirectly tested by future PRs.

@monperrus
Copy link
Collaborator

Excellent, baby steps are great!

Is it possible to have better typing such as

enter(CtElement element); // instead of Object
exit(CtElement element);

@pvojtechovsky
Copy link
Collaborator Author

Good idea, I came to some one at the same time too. ;-)

Done.

@monperrus
Copy link
Collaborator

Just made a doc PR on this one: pvojtechovsky#13

@monperrus monperrus merged commit c0aba9b into INRIA:master Mar 9, 2017
@pvojtechovsky pvojtechovsky deleted the CtScannerListener branch March 9, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants