review CatchVariableReferenceFunction, CatchVariableScopeFunction #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
force-pushed
the
CatchVariableReferenceFunction
branch
from
551b438
to
e24c1e1
Compare
pvojtechovsky
changed the title
|
I do not need more tests for this PR. It was conflict solving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains CatchVariableReferenceFunction, CatchVariableScopeFunction.
The main purpose is CatchVariableReferenceFunction, which returns all the references to the catch variable. The second on is helper classes which might be useful for others so it is public.
It depends on PR CtQuery#filterChildren(null) #1140
The tests will be added later, because they share a lot with tests of #1136