review LocalVariableReferenceFunction, LocalVariableScopeFunction #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
force-pushed
the
LocalVariableReferenceFunction
branch
from
f8d4686
to
7b8b3a2
Compare
pvojtechovsky
changed the title
surli
reviewed
Jan 30, 2017
| public void apply(CtLocalVariable<?> localVariable, CtConsumer<Object> outputConsumer) { | ||
| CtStatementList statements = localVariable.getParent(CtStatementList.class); | ||
| if (statements == null) { | ||
| //cannot search for parameter references of parameter which has no executable |
There was a problem hiding this comment.
Wrong comment I think. But don't you want to tests emptyness of the statementList here too?
There was a problem hiding this comment.
comment was wrong. Thanks. The check for statement.isEmpty() is not needed because it later searches in the statements list and throws exception in case of empty collection too. So this case is handled too.
pvojtechovsky
force-pushed
the
LocalVariableReferenceFunction
branch
from
b9f9010
to
e5a51a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains LocalVariableReferenceFunction, LocalVariableScopeFunction.
The main purpose is LocalVariableReferenceFunction, which returns all the references to the local variable. The second on is helper classes which might be useful for others so it is public.
It depends on PR
CtQuery#filterChildren(null)#1140The tests will be added later, because they share a lot with tests of #1136