fix(comment): support comment on string concatenation #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
reviewed
Jan 18, 2017
| assertEquals("\"\" + (\"\"// comment multi line string" + newLine | ||
| + " + \"\")", ctLocalVariableString.getDefaultExpression().toString()); | ||
|
|
||
| CtReturn ctReturn = m1.getBody().getStatement(13); | ||
| assertEquals(createFakeComment(f, "comment return"), ctReturn.getComments().get(0)); |
There was a problem hiding this comment.
I'm not sure to understand the relation between your changes and the new test: you change the behaviour of comments for conditionnals, if and executables and you test a multiline string?... I think I miss something.
There was a problem hiding this comment.
It is complex...
Now I print comments of CtExpression.
These lines was basically there to handle CtExpressions present in CtConditional (may not work for other expression).
if (!(thenExpression instanceof CtStatement)) {
elementPrinterHelper.writeComment(thenExpression, CommentOffset.BEFORE);
}Now I handle the comment of every CtExpression.
More over I added a position for the string concatenation.
This way JDTCommentBuilder is able to handle the comment in string.
tdurieux
force-pushed
the
fix_comment_string
branch
from
95791c0
to
18d829a
Compare
tdurieux
force-pushed
the
fix_comment_string
branch
from
18d829a
to
d02d30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1123