Fix #1100 #1103
Merged
Fix #1100 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I am sorry, didn't notice that this test fails. Trying to fix it asap. |
|
Any chances that this PR will be in 5.5.0? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the test for #1100.This PR fixes
ReferenceBuilder#getLambdaExecutableReferencewhich is supposed to find the executable reference of variables located in lambdas. Until now, this method used to return the outermost lambda instead of the innermost.Furthermore, the parameter type of unknown parameters is set toObjectinstead of being skipped.This will be fixed in a separate PR.