Skip to content

Commit

Permalink
fix(MavenLauncher): Improving MavenLauncher dependency resolution (#2112
Browse files Browse the repository at this point in the history
)

* add a test for getRoleInParent / getValueByRole consistence

* fix: MavenLauncher resolve dependancies which version is defined in parent pom, and other corner cases

* feat(MavenLauncher): MavenLauncher now get its classpath from a maven invocation

* clean(MavenLauncherTest): remove unused import

* Update MavenLauncherTest.java

* POC MavenLauncher implementation with MavenCli

* cleanup(MavenLauncherTest)

* refactor(MavenLauncher): use MavenInvoker

* set up M2_HOME environement variable in travis

* revert previous travis changes

* Update .travis.yml

* Add headers

* debugging travis script jdk10

* refactoring, update certificate on travis script for java 10

* stop deleting files before reading them...

* yet another attempt at fixing travis build with java 10

* yet another attempt at fixing travis build with java 10

* switch to multi classpath files

* this certificate problem is getting annoying

* fail first

* Post review improvements

* fix some exception handeling, add a reflexive test to check that all type references point to resolvable types
  • Loading branch information
nharrand authored and surli committed Aug 9, 2018
1 parent 0047415 commit eed3e53
Show file tree
Hide file tree
Showing 10 changed files with 985 additions and 650 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ group: edge
jdk: openjdk8

env:
global:
- M2_HOME="/usr/local/maven"
matrix:
- SCRIPT=travis-jdk9.sh
- SCRIPT=travis-jdk8.sh
- SCRIPT=travis-coverage.sh
Expand Down
4 changes: 3 additions & 1 deletion chore/travis/travis-jdk10.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
chmod +x install-jdk.sh

export JAVA_HOME=$HOME/openjdk8
source ./install-jdk.sh -f 10

# Use the default (the one present in the base container) collection of trusted certificate authority (CA) certificates for java
source ./install-jdk.sh -f 10 -c

mvn -Djava.src.version=1.10 test
7 changes: 6 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>3.3.9</version>
<version>3.5.0</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down Expand Up @@ -284,6 +284,11 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-invoker</artifactId>
<version>3.0.1</version>
</dependency>
</dependencies>

<build>
Expand Down
Loading

0 comments on commit eed3e53

Please sign in to comment.