refactor: remove redundant casts (#2478)

INRIA · Sep 18, 2018 · 99043d9 · 99043d9
1 parent 661a3a8
commit 99043d9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/spoon/support/reflect/reference/CtExecutableReferenceImpl.java b/src/main/java/spoon/support/reflect/reference/CtExecutableReferenceImpl.java
@@ -137,7 +137,7 @@ private CtExecutable<T> getCtExecutable(CtType<?> typeDecl) {
 				Launcher.LOGGER.error(e.getMessage(), e);
 			}
 		} else if (method == null && getSimpleName().startsWith(CtExecutableReference.LAMBDA_NAME_PREFIX)) {
-			final List<CtLambda> elements = (List<CtLambda>) typeDecl.getElements(new NamedElementFilter<>(CtLambda.class, getSimpleName()));
+			final List<CtLambda> elements = typeDecl.getElements(new NamedElementFilter<>(CtLambda.class, getSimpleName()));
 			if (elements.isEmpty()) {
 				return null;
 			}

diff --git a/src/test/java/spoon/generating/CtBiScannerGenerator.java b/src/test/java/spoon/generating/CtBiScannerGenerator.java
@@ -88,7 +88,7 @@ public void process() {
 				replace.addArgument(factory.Code().createInvocation(otherRead, ((CtInvocation) replace.getArguments().get(1)).getExecutable()));
 
 				if ("Map".equals(targetInvocation.getExecutable().getType().getSimpleName())) {
-					((CtExpression) replace.getArguments().get(1)).replace(factory.Code().createInvocation(targetInvocation, factory.Executable().createReference("List Map#values()")));
+					replace.getArguments().get(1).replace(factory.Code().createInvocation(targetInvocation, factory.Executable().createReference("List Map#values()")));
 					CtInvocation invocation = factory.Code().createInvocation(replace.getArguments().get(2).clone(), factory.Executable().createReference("List Map#values()"));
 					replace.getArguments().get(2).replace(invocation);
 				}

diff --git a/src/test/java/spoon/test/arrays/ArraysTest.java b/src/test/java/spoon/test/arrays/ArraysTest.java
@@ -139,7 +139,7 @@ public void testParameterizedTypeReference() throws Exception {
 		//contract: check actual type arguments of parameter type: List<?>
 		CtType<?> ctClass = ModelUtils.buildClass(VaragParam.class);
 		CtParameter<?> param1 = ctClass.getMethodsByName("m4").get(0).getParameters().get(0);
-		CtTypeReference<?> typeRef = (CtTypeReference<?>) param1.getType();
+		CtTypeReference<?> typeRef = param1.getType();
 		assertEquals("java.util.List<?>", typeRef.toString());
 		assertEquals(1, typeRef.getActualTypeArguments().size());
 	}

diff --git a/src/test/java/spoon/test/executable/ExecutableRefTest.java b/src/test/java/spoon/test/executable/ExecutableRefTest.java
@@ -103,7 +103,7 @@ private CtAbstractInvocation<?> getInvocationFromMethod(String methodName) throw
 		assertEquals(1, methods.size());
 
 		CtMethod<?> ctMethod = methods.get(0);
-		CtBlock<?> ctBody = (CtBlock<?>) ctMethod.getBody();
+		CtBlock<?> ctBody = ctMethod.getBody();
 		Assert.assertNotNull(ctBody);
 
 		List<CtStatement> ctStatements = ctBody.getStatements();