Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: a 403 page captures all transitions to the settings page #1862

Closed
jniles opened this issue Jul 14, 2017 · 0 comments · Fixed by #1874
Closed

bug: a 403 page captures all transitions to the settings page #1862

jniles opened this issue Jul 14, 2017 · 0 comments · Fixed by #1874
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Jul 14, 2017

If a user hits a 403 page, the cannot go to the "Settings" page to logout. The page captures all other transitions and refuses to let the user navigate away.
@jniles jniles added the Bug label Jul 14, 2017
@jniles jniles self-assigned this Jul 17, 2017
jniles added a commit to jniles/bhima that referenced this issue Jul 17, 2017
@jniles
fix: allow navigation to settings after 403 error
2ba3466 
This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes Third-Culture-Software#1862.
@jniles jniles mentioned this issue Jul 17, 2017
Merged
bors bot added a commit that referenced this issue Jul 18, 2017
@bors
Merge #1866 #1867 #1874
c7f645c 
1866: feat(patients): accept any document upload r=jniles

This commit allows any document to be uploaded and attached to a
patient.  It also updates the document upload modal with the latest
header crumb and translate directives.

Closes #1823

1867: Fix: ui select option rendering r=jniles

For some reason, a `ui-select` can only have a single `<span>` element within due to a miscreated CSS selector in the bootstrap css theme.  Otherwise, the text is not labeled on the same line and is misaligned.  This PR fixes those issues in the prices.html file and the inventory management page.

It also uses the `translate` directive where applicable.

Closes #993.  Closes #1720.

1874: fix: allow navigation to settings after 403 error r=jniles

This commit fixes a small bug does not a user log out after they have
hit the 403 state.

Closes #1862.
@bors bors bot closed this as completed in #1874 Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow navigation to settings after 403 error jniles/bhima
1 participant
@jniles