Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron: Support KS/UI forms #8736

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mjansenDatabay
Copy link
Contributor

With this commit cron job implementations
are allowed to migrate from legacy forms
to the UI/KS forms.

An instance of ilCronJob can provide a
boolean false when overriding usesLegacyForms
and then simply provide own implementations of
getCustomConfigurationSections and
saveCustomConfiguration.

With this commit cron job implementations
are allowed to migrate from legacy forms
to the UI/KS forms.

An instance of `ilCronJob` can provide a
boolean `false` when overriding `usesLegacyForms`
and then simply provide own implementations of
`getCustomConfigurationSections` and
`saveCustomConfiguration`.
@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Dec 16, 2024
@mjansenDatabay mjansenDatabay self-assigned this Dec 16, 2024
@mjansenDatabay
Copy link
Contributor Author

Since this (kind of) adds new methods to the public interface (here: abstract base class) and contains an announcement regarding future removals of methods, I'll tag this PR with the JF label.

@klees
Copy link
Member

klees commented Dec 17, 2024

Hi @mjansenDatabay,

really looking forward to this!

I have two questions:

  • For my curiosity about that new #[\Deprecated(...)] construction: Is the second parameter a version?
  • Regarding the design: For the Activities we are currently trying to solve a somewhat similar problem. We decided to just use FormInput there. Due to the monoidal structure of the inputs, we can simply treat a group of (sections of groups of ...) inputs as a simple input. This makes the interface simpler but also the implementation on our end, while still offering a great deal of flexibility to our users. Did you consider this option too? Is there a strong reason to use an array of sections here?

Kind regards!

@mjansenDatabay
Copy link
Contributor Author

Hi @klees ,

For my curiosity about that new #[\Deprecated(...)] construction: Is the second parameter a version?

Yes, that's the ILIAS version. I used the syntax shown here https://wiki.php.net/rfc/deprecated_attribute .

Regarding the design

To answers this, I'll have to first study the references you mentioned above. I will, but not before January (tomorrow is my last working day in 2024).

Best regards,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement jour fixe php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants