Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: remove option to manage recommended content #8641

Conversation

iszmais
Copy link
Contributor

@iszmais iszmais commented Dec 5, 2024

https://mantis.ilias.de/view.php?id=43103

This seems to be a conceptional flaw of the dashboard refactoring.

Recommended content is not individually managed but by role.
Therefore, there is no way for a user to change that content.

@fhelfer FYI

@oliversamoila
Copy link

@iszmais
Copy link
Contributor Author

iszmais commented Dec 6, 2024

@oliversamoila Thank you for your feedback.

This PR only targets the "multi manage" ability of recommended content, not the management in general.
This function was never implemented and therefore does not work. It just slipped in during the refactoring/streamlining of content blocks for ILIAS 9.

We may add this in future, but that should be within a feature request and not within a bugfix.

Greetings,
@iszmais

@iszmais iszmais requested a review from oliversamoila December 6, 2024 12:12
@iszmais
Copy link
Contributor Author

iszmais commented Dec 6, 2024

@oliversamoila Due to that clarification step, I would like you to give a conceptional approval as verification to my statement.

Alternatively, feel free to discuss any open points or suggest this to the JF.

@oliversamoila
Copy link

oliversamoila commented Dec 9, 2024

Thanks @iszmais

I was reasonably sure that all the streamlining efforts in Global Dashboard Settings of Presentation and Sortation for all Dashboard Sections, Global Sorting for Dashboard Sections & KS-ViewControls for Dashboard Sections
also included this.

However, this is simply not explicit at all. I can certainly understand the view from this PR. No well-founded objections. 😉

@iszmais iszmais merged commit 3e930c0 into ILIAS-eLearning:release_9 Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants