[FEATURE] ILIASObject: remove ilProgressBar
usage
#8270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kergomard,
I have replaced the legacy
ilProgressBar
usage as fast and good as I could. I am not quite sure, if this code is actually reachable, because when copying multiple (nested) objects, the page simply loads without ever showing theilObjectCopyProgressTableGUI
table. Maybe you can try this out yourself?Also note, I have replaced the legacy usage as is. I believe we should not render multiple progress bars on this page in the future, but instead use one progress bar to cover the progress of all objects being copied. I also needed to provide the
_max_steps
as an URL parameter, because there is (currently) no way to ping-pong the max-value of the progress bar.Further note, this PR contains an additional commit which needs to be merged first. see #8268
Kind regards,
@thibsy