-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline LaTeX usage #8256
base: trunk
Are you sure you want to change the base?
Streamline LaTeX usage #8256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in "my" components LGTM!
Hi @fneumann Thx a lot for this big and important contribution. We looked over the UI related changes. We agree with the core concepts. However, there are public interface changes which need JF approval and several smaller things that need discussion and/or changes. This is more than can be achieved until tomorrow evening. Therefore, we are afraid, this will be too tight for the upcoming release. We would appreciate it if you contact us early, especially when we approach deadlines. We are willing to help push a large project over tight deadlines; however, we need to sync the workload if time-consuming tasks like this need fast processing. Note, UI changes are release-independent. It could be possible to merge them, after the release date. However, this is not the case for the implementation of the underlying FR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @fneumann
Even if this is not for ILIAS 10, I approve the changes for the Test, this way you do not need for us, once this is done.
Best,
@kergomard
I remove the 'dependency' tag for this PR as it is about code changes for 11 and not related to a dependency we have to discuss at the Dependency JF. For the MathJax dependency there should be a proper PF. |
Feature Request:
https://docu.ilias.de/go/wiki/wpage_5614_1357
Description:
https://github.com/fneumann/ILIAS/blob/dev10-streamline-latex/components/ILIAS/UI/docs/mathjax.md
A review would be needed for components with the major changes:
Since changes in Accordion, Export, Utilities, Setup, SCORM2004 are trivial I think there is no need for a dedicated review there.
Some technical notes:
components/ILIAS/UI/resources/js/MathJax/mathjax.js
which is copied to the public folder sets the MathJax configuration in the browser and loads MathJax asynchronously.ilInitialisation::initUIFramework
to create a data object implementing the interface\ILIAS\UI\Implementation\Render\MathJaxConfig
which is provided for the UI framework.MathJaxConfig
is also provided via DIC for the components to control the display of the MathJax hints, mostly below textarea form elements that support MathJax.