Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Testsuite for UI components - adding missing descriptions and … #8252

Closed

Conversation

lukastocker
Copy link
Contributor

…expected output to examples from Testrail (ILIAS core > Test Suites & Cases > UI-Service).

This PR is build on PR No. 6885.
Therefore its commits are also included in this PR. Please ignore them and just concentrate on my commit.
This PR should be merged after PR 6885 is merged - not before.

@lukastocker
Copy link
Contributor Author

Please note:
Following Testrail Tests are not up-to-date:

  • Menu > Sub
  • ViewControl > Pagination no_pages

Following directories/files are missing a specific testcase in Testrail:

  • Button > Minimize
  • Card > Sdt > with_sections & with_title_action
  • Card > RepositoryObject > (alle examples)
  • Chart > Bar (horizontal and vertical)
  • Dropzone > File > Standard > bulky
  • Entity > (all examples)
  • Help > (all examples)
  • Image > Standard > with_additional_on_load_code, with_signal_action, with_string_action
  • Image > Responsive > with_additional_high_resolution_source
  • Input > Container > Form > Std > with_required_input
  • Input > Field > ColorPicker
  • Input > Field > Markdown
  • Input > ViewControll > (all examples)
  • Layout > Alignment (all examples)
  • Listing > Entity
  • Listing > Property
  • MainControls > (all examples)
  • Modal > LightboxCardPage > show_modal_on_button_click
  • Panel > Sub > with_secondary_panel
  • Table > Action (all examles)
  • Table > Column (all examles)
  • Table > Data (all examles)
  • Table > Presentation > without_data
  • Symbol > Glyph > Bold
  • Symbol > Glyph > Header
  • Symbol > Glyph > Italic
  • Symbol > Glyph > Launch
  • Symbol > Glyph > Link
  • Symbol > Glyph > Sortation

@lukastocker lukastocker force-pushed the 9/UI/buildTestCases branch 3 times, most recently from 806a603 to 7909fe8 Compare October 23, 2024 14:02
@lukastocker
Copy link
Contributor Author

lukastocker commented Oct 23, 2024

Additional Note:

I am unsure why the checks (8.1, 8.2) are failing for the php-cs-fixer. We looked into the issue but couldn't find a reason why the process exits with code 8. Locally it runs fine. The PR is up-to-date with the latest release_9 branch.

Copy link
Contributor

@Amstutz Amstutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukastocker

Thx a lot for this. I was reading through the texts and noted the types down. However, GitHub became extremely slow while nearing 100 proposed changes, so I stopped. We should, however, go through the rest once merged. I made it up to Input / Text (in alphabetical order).

src/UI/examples/Button/Bulky/base.php Outdated Show resolved Hide resolved
src/UI/examples/Button/Bulky/engaged.php Outdated Show resolved Hide resolved
src/UI/examples/Button/Bulky/with_tooltip.php Outdated Show resolved Hide resolved
src/UI/examples/Button/Close/base.php Outdated Show resolved Hide resolved
src/UI/examples/Button/Close/base.php Outdated Show resolved Hide resolved
src/UI/examples/Input/Field/Tag/base_with_data.php Outdated Show resolved Hide resolved
src/UI/examples/Input/Field/Tag/base_with_data.php Outdated Show resolved Hide resolved
src/UI/examples/Input/Field/Tag/disabled.php Outdated Show resolved Hide resolved
src/UI/examples/Input/Field/Text/base.php Outdated Show resolved Hide resolved
src/UI/examples/Input/Field/Text/disabled.php Outdated Show resolved Hide resolved
@Amstutz
Copy link
Contributor

Amstutz commented Oct 25, 2024

@klees feel free to proceed as you deem fit, this is good for me.

@klees
Copy link
Member

klees commented Oct 25, 2024

Included as a63d169

@klees klees closed this Oct 25, 2024
@klees
Copy link
Member

klees commented Oct 25, 2024

Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants