10/UI/allow view controls in reporting panels #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsstrassner
changed the title
kergomard
force-pushed
the
10/ui/allow_view_controls_in_reporing_panels
branch
from
a4866ed to
4cf002e
Compare
|
Hi @kergomard, please present this on the JF. Thanks! |
|
Jour Fixe, 30 SEP 2024: We highly appreciate this suggestion and accept the PR for ILIAS 10/trunk. |
|
Thx a lot @kergomard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear coordinators
This PR would introduce the possibility to add view controls to reporting panels. I built it on top of #7972 as this gave the opportunity to remove some code duplication, but please let me know, if you would prefere me to not do that and simply add the duplicate code.
I added the same constraints on view controls as we have in the standard panels and I think there are cases where all three types could be used reasonably. I don't think there is a justification for also adding the section view contro, though.
Thank you very much in advance and best,
@kergomard
PS: The failing tests are from the copyright checker, I will fix them in one go.