UI Components, New Glyphs for il-icons fonts see #41767 #7925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Amstutz Thank you a lot for contributing to ILIAS. This significantly improves the glyph database. I just have one question according to the Files changed: Please answer the following questions:
kindly, |
thibsy
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks a lot for your contribution to the UI components!
The factory descriptions are plausible and can be presented at the next JF. There are some minor changes before we can merge this afterwards, but they are not important for JF.
Please implement the following changes:
- Unit tests: the unit tests are currently failing. Please look into this.
-
ilias_de.lang: the german translation ofcommon#:#tile_viewis in english. Please translate this variable. -
@inheritDoc: this PHPDoc annotation is obsolete and can be removed from the new methods in theGlyph\Factoryimplementation.
|
Jour Fixe, 30 SEP 2024: We highly appreciate this suggestion and accept the PR for ILIAS 10/trunk. |
JF Decision 30.09.2024
…ering and range. (ILIAS-eLearning#8106) * Fix https://mantis.ilias.de/view.php?id=41328 * Fix https://mantis.ilias.de/view.php?id=42095 * Remove Table\Data::withNumberOfRows() * Replace IRSS usage of removed method
…n of an item object from tile to list view
…ool leads to fatal PDOException
…Step 2) (ILIAS-eLearning#8129) * Update ilias_de.lang
UnitTests have been modified in LTIProvider to disable them until the new required dependencies are fully integrated into the LTI components.
This commit extracts the code to conditionally prepend a reply-prefix to the subject of the related parent posting from class `ilObjForumGUI` to a separate class. Furthermore, a unit test is added which tests different variants of language variables defined as "reply prefix" (e.g. "Re: "), "repeated reply prefix" and "optimized repeated reply prefix" (e.g. "Re (4)"). The main challenge is that the prefixes are defined in language files and can be changed in the advanced language administration. The code has to be robust against these changes. However, the prefix-builder does not need to support any arbitrary translations (shit in, shit out). Finally: The prefix-builder should be "multibyte safe", so it uses the `mb_*` PHP functions if available. See: https://mantis.ilias.de/view.php?id=42322 (cherry picked from commit 2316d1d) (cherry picked from commit 575e2d0)
Skipped LTIProvider component UnitTests temporarily
This commit extracts the code to conditionally prepend a reply-prefix to the subject of the related parent posting from class `ilObjForumGUI` to a separate class. Furthermore, a unit test is added which tests different variants of language variables defined as "reply prefix" (e.g. "Re: "), "repeated reply prefix" and "optimized repeated reply prefix" (e.g. "Re (4)"). The main challenge is that the prefixes are defined in language files and can be changed in the advanced language administration. The code has to be robust against these changes. However, the prefix-builder does not need to support any arbitrary translations (shit in, shit out). Finally: The prefix-builder should be "multibyte safe", so it uses the `mb_*` PHP functions if available. See: https://mantis.ilias.de/view.php?id=42322 (cherry picked from commit 2316d1d) (cherry picked from commit 575e2d0)
This commit extracts the code to conditionally prepend a reply-prefix to the subject of the related parent posting from class `ilObjForumGUI` to a separate class. Furthermore, a unit test is added which tests different variants of language variables defined as "reply prefix" (e.g. "Re: "), "repeated reply prefix" and "optimized repeated reply prefix" (e.g. "Re (4)"). The main challenge is that the prefixes are defined in language files and can be changed in the advanced language administration. The code has to be robust against these changes. However, the prefix-builder does not need to support any arbitrary translations (shit in, shit out). Finally: The prefix-builder should be "multibyte safe", so it uses the `mb_*` PHP functions if available. See: https://mantis.ilias.de/view.php?id=42322 (cherry picked from commit 2316d1d) (cherry picked from commit 575e2d0)
… new_glyphs_10 * 'new_glyphs_10' of https://github.com/Amstutz/ILIAS: UI Components, New Glyphs for il-icons fonts see #41767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of 6 new Glyphs with description and font changes, see https://mantis.ilias.de/view.php?id=41767 for details.