Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] increase max object import-id length to 255 characters. #7918

Merged

Conversation

thibsy
Copy link
Contributor

@thibsy thibsy commented Aug 8, 2024

Hi folks,

This PR simply increases the maximum length of ILIAS object import-ids from 50 characters to 255.
We have recently hit this capacity for one of our customer installations, which uses somewhat complex external ids.
Therefore, I suggest to increase this limitation.

Kind regards,
@thibsy

@thibsy thibsy added improvement php Pull requests that update Php code Looking for Shepherd labels Aug 8, 2024
@dsstrassner
Copy link
Contributor

At some point, the wolf comes and chases the shepherd away.

@kergomard
Copy link
Contributor

Thanks @thibsy
I will get around to this asap, simply as a reminder that you can assign ILIASObject PRs to me, so they don't stay around for too long.

Best,
@kergomard

@kergomard kergomard self-assigned this Aug 8, 2024
@thibsy
Copy link
Contributor Author

thibsy commented Aug 8, 2024

Hi @kergomard,

Thx for the reminder! I was looking at an old maintenance file and forgot you took over the authority here :) (therefore the shepherd label).

Kind regards,
@thibsy

@kergomard
Copy link
Contributor

Hi @thibsy
No problem! I just reacted, because it was the second time within 1 hour this happened, and I started to wonder ;-) . I monitor all PRs so I will notice anyways.

Have a nice evening,
@kergomard

@kergomard kergomard merged commit 3894800 into ILIAS-eLearning:release_8 Sep 27, 2024
3 checks passed
@kergomard
Copy link
Contributor

Thank you very much @thibsy. I merged this and picked to ILIAS 9 and trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants