T&A 24969: Conceptual issue with (de)activating public comments in pools #7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuszych
force-pushed
the
ta/24969
branch
2 times, most recently
from
c6e04ca to
df958f6
Compare
thojou
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Hey @matheuszych,
As discussed, we should handle the custom checkAccess within the T&A Modules without modifying the central Notes Service.
- Rework the access check for comments to be managed within the T&A module
Thanks!
|
@thojou I believe this should be a more appropriate approach. |
…nting is enabled in question pool
thojou
approved these changes
Jul 12, 2024
|
Will try to look into it this Weekend. |
dsstrassner
approved these changes
Jul 18, 2024
oliversamoila
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
I have looked at this along explanations and demonstration video in https://mantis.ilias.de/view.php?id=24969#c106506 and thank you for the changes.
|
Hey @matheuszych, i took your PR and cherry-picked the changes into trunk. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read and write access to QuestionPool comments is not checked properly and this should resolve that.
Mantis: 24969