Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Bugfix #0041637: Course Certificates aren't issued in the language of the receiving user in any case (month names) #7764

Merged

Conversation

fhelfer
Copy link
Contributor

@fhelfer fhelfer commented Jul 4, 2024

references and depends on merge of #7758

@dsstrassner
Copy link
Contributor

hi @mjansenDatabay, I assume we wait for #7759?

@mjansenDatabay
Copy link
Contributor

@dsstrassner Yes, all these PRs depend on #7759

@mjansenDatabay
Copy link
Contributor

All relevant/ref. PRs have been merged, so this can be merged as well (after @fhelfer resolved the conflict here).

@mjansenDatabay mjansenDatabay added the php Pull requests that update Php code label Sep 19, 2024
@fhelfer fhelfer force-pushed the certificate/mantis/41637-test branch from e725c98 to f3aa68d Compare September 19, 2024 07:24
@dsstrassner dsstrassner requested review from kergomard and removed request for mjansenDatabay September 19, 2024 08:05
@dsstrassner
Copy link
Contributor

@kergomard will you be so kind.

@kergomard
Copy link
Contributor

Thank you very much for the PR @fhelfer

Could you please remove the use ilObjUser and fix the test, I will then merge.

Thanks and best,
@kergomard

@fhelfer
Copy link
Contributor Author

fhelfer commented Sep 19, 2024

Thank you very much for the PR @fhelfer

Could you please remove the use ilObjUser and fix the test, I will then merge.

Thanks and best, @kergomard

Done

@kergomard kergomard merged commit d574589 into ILIAS-eLearning:trunk Sep 19, 2024
2 of 3 checks passed
@kergomard
Copy link
Contributor

Thank you very much @fhelfer !

@fhelfer fhelfer deleted the certificate/mantis/41637-test branch November 20, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants