Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataCollection: Fix comments rendering on records #7734

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ public function doExtReplace(array $found): ?string
protected function renderComments(bool $edit = false): string
{
if (!$edit) {
return $this->notesGUI->getCommentsHTML();
return $this->notesGUI->getListHTML();
} else {
return $this->notesGUI->editNoteForm();
}
Expand Down Expand Up @@ -408,7 +408,7 @@ private function loadSession(): void
);
//we then partially load the records. note that this also fills up session data.
$this->table->getPartialRecords(
(string)$this->table->getId(),
(string) $this->table->getId(),
$list->getOrderField(),
$list->getOrderDirection(),
$list->getLimit(),
Expand Down
Loading