ModeInfo/UI Demo: fix example for modeinfo #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhaagen
force-pushed
the
_trunk/UI/ModeInfo
branch
from
02e8d18 to
36f2c39
Compare
|
Thx for improving the example. what exactly was broken? note that tests are failing atm. |
nhaagen
force-pushed
the
_trunk/UI/ModeInfo
branch
from
5f7a57e to
f237c81
Compare
|
Links to the fullscreen were not working (script-url was changed), and the page was rendering without CSS/JS. |
|
Sorry about the fuss; I found some more issues, basically all examples rendering a full page. |
|
Looking much better know, thx a lot for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the example for ModeInfo; also, the button was very unobstrusive.