Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: passed 'rule_id' MUST be of type int #4797

Closed
wants to merge 2,239 commits into from

Conversation

utesche
Copy link
Contributor

@utesche utesche commented Jul 18, 2022

otherwise a TypeError Exception is raised:

TypeError thrown with message "Argument 1 passed to ilLDAPRoleAssignmentRule::_getInstanceByRuleId() must be of the type int, string given, called in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRules.php on line 103"

Stacktrace:
#14 TypeError in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRule.php:62
#13 ilLDAPRoleAssignmentRule:_getInstanceByRuleId in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRules.php:103
#12 ilLDAPRoleAssignmentRules:getAssignmentsForUpdate in /.../Services/LDAP/classes/class.ilLDAPAttributeToUser.php:140

mjansenDatabay and others added 30 commits April 29, 2022 11:39
…md-editor-tpl

MedaData/LOM: Fix editing of metadata
…ot/npm_and_yarn/path-parse-1.0.7

Bump path-parse from 1.0.6 to 1.0.7
Typo in assessment#:#intprecision_info#
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@yaireo/tagify](https://github.com/yairEO/tagify) from 4.9.4 to 4.9.8.
- [Release notes](https://github.com/yairEO/tagify/releases)
- [Commits](https://github.com/yairEO/tagify/commits/v4.9.8)

---
updated-dependencies:
- dependency-name: "@yaireo/tagify"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
proposed fix for 31263: falsche Rückmeldung bei mehreren Durchläufen
…28558

TestQuestionPool: Add SQL indexes for cloze question
…ymous

commit b6c0f1600c483f3d91e0b86243da6d5a00351988
Author: Fabian Schmid <[email protected]>
Date:   Thu May 5 10:32:28 2022 +0200

    Implemented hasVisibleItems for Collectors

commit 03dc5d97fab322c387e8acad493a9e002fda7ef0
Author: Timon Amstutz <[email protected]>
Date:   Fri Apr 22 14:36:53 2022 +0200

    Global Screen, Empty Mainbar, fix for #31844
…-sorting7

Remove Personal Desktop Sidebar sorting from dashboard in ILIAS 7
nicoroeser and others added 26 commits July 8, 2022 13:56
Change the “Results and Grades” table in the test results tab so that it
shows the short form of grades instead of the official form.

This harmonizes the displayed marks with the current forms shown by the
statistics table and used in the results export file.

Warning:
changes the form of the data in the ‘finalMark’ field in scoring
objects (instances of class ‘ilTestParticipantScoring’). Although this
is probably a good thing, it it a change of data provided through a
public interface, and code using it (e.g. in plugins) might require
adaptation.

The modified code is also utilized by the SOAP web interface for its
implementation of getTestResults, but that SOAP code does not use the
marks so it should not be negatively affected.

Fixes <https://mantis.ilias.de/view.php?id=31209>.
…eLearning#4742)

* fixed XSS, added workaround to avoid stripping of non-html characters

* changed workaround

* changed workaround
…epicker-test-7

Test: Refactor 0028385: Plausibilitätsprüfung Tests
…_test_results_table-mantis31209-release_7

T&A: use short form of grade in test results table (Mantis #31209) (release_7)
…tpl_sessions

fixes 21972 by adding adding didactic templates to session settings
otherwise a TypeError Exception is raised:

TypeError thrown with message "Argument 1 passed to ilLDAPRoleAssignmentRule::_getInstanceByRuleId() must be of the type int, string given, called in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRules.php on line 103"

Stacktrace:
ILIAS-eLearning#14 TypeError in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRule.php:62
ILIAS-eLearning#13 ilLDAPRoleAssignmentRule:_getInstanceByRuleId in /.../Services/LDAP/classes/class.ilLDAPRoleAssignmentRules.php:103
ILIAS-eLearning#12 ilLDAPRoleAssignmentRules:getAssignmentsForUpdate in /.../Services/LDAP/classes/class.ilLDAPAttributeToUser.php:140
@utesche utesche changed the base branch from release_7 to trunk July 18, 2022 14:05
@utesche
Copy link
Contributor Author

utesche commented Jul 18, 2022

PR was originally assigned to release_7, but intended target was trunk.
PR is closed and a new, correct PR follows...

@utesche utesche closed this Jul 18, 2022
@utesche utesche deleted the patch-4 branch November 24, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.