Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes for edit question #4655

Merged
merged 1 commit into from
Jun 20, 2022
Merged

More fixes for edit question #4655

merged 1 commit into from
Jun 20, 2022

Conversation

kergomard
Copy link
Contributor

This finalizes the work started in the following PR : #4642

  • It makes sure that the "Finish Editing"-Link in the Question Page always leads to the right page.
  • It also makes sure that the "Back"-Links always points to the test and not suddenly to a none existent question pool

I opted for shortness of the implementation and thus added the same parameters to all calls. Not all of them are always necessary, but I would suggest to let this slide and fix it when we tackle the rather wonky command-flow.

@kergomard kergomard added bugfix php Pull requests that update Php code labels Jun 15, 2022
@kergomard kergomard mentioned this pull request Jun 15, 2022
Merged
@mbecker-databay
Copy link
Contributor

Looks good to me, thank you so much!

@mbecker-databay mbecker-databay merged commit f78e4f4 into ILIAS-eLearning:release_7 Jun 20, 2022
@kergomard kergomard deleted the fix_editing_links_question_table_in_test branch September 27, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbecker-databay mbecker-databay

@dsstrassner dsstrassner

Labels
bugfix php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kergomard @mbecker-databay @dsstrassner