PHP 8: Code Review UIComponent
#4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjansenDatabay
commented
Mar 17, 2022
| @@ -32,7 +32,6 @@ class ilSkillSelectorGUI extends ilVirtualSkillTreeExplorerGUI | |||
| protected $select_gui = ""; | |||
| protected string $select_cmd = ""; | |||
| protected string $select_par = ""; | |||
| protected bool $select_multi = false; | |||
There was a problem hiding this comment.
@alex40724 I had to move this to the base class, because it is also used there, and without my changes this was dynamically declared in the base class.
|
We are using the latest geshi version now. It does not explicit state to be compatible with PHP8, however I tested the code elements in the page editor and they work flawlessly. |
|
Thanks for the review and changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alex40724,
I completed the review of the
Services/UIComponentcomponent.This component looked very good, I only found one file where the coding style was not compliant. Furthermore I had to add a few types here and there.
Results:
PSR-2 + Xcompliant$_GET/$_POST/$_REQUEST/$_SESSIONUnit Test Suitewith at least one unit testPhpStorm Code Inspectionissues leftI am not sure whether https://packagist.org/packages/geshi/geshi (used by
Services/UIComponent/SyntaxHighlighter) is compatible with PHP 8. Please check the list item above if you already checked this.I also fixed some trivial issues reported by my inspection profile.
Best regards,
@mjansenDatabay