-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Interface for Toast Container
#4049
UI: Interface for Toast Container
#4049
Conversation
It's gonna be me, @Amstutz isn't available this week... |
In the material design of Google which defined the wording "Toast" a toast is a notification without an action. Reference: https://material.io/archive/guidelines/components/snackbars-toasts.html |
Honestly a valid point @PurHur, but the term was defined by the |
I understand your comment. I was just writing that comment, because it was the fist time i encountered these code lines. I understand that this is not the original PR, but i cant look over all comments on all different platforms for the illias development, this is outside of my work scope. This would take tooooo much time. So i just wrote it here to give at least some feedback which could be read. I dont expect that this have any inpact, if you dont like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, thanks a lot. I left some inline comments, hope it is ok that I did not leave a fully-fledged review...
Jour Fixe, 21 FEB 2022 : We highly appreciate this suggestion and accept the PR for ILIAS 8. |
@matthiaskunkel thanks for the appreciation! @klees feel free to merge or to give some minor feedback if needed. |
Toast Container
This PR proposes to introduce the UI-Component for implementing Containers for Toasts.
Toast Container:
The Toast Container is a wrapper without direct visual represantation which centralizes the handling and accessebility of Toast components.
A Toast Container can appear in the top right corner , overlaying the ILIAS UI. It can contain and handle Toasts Components and present them to a screen reader. There is not direct way to interact with the Container itself. If the Container does not contain any Toast Components it has no effect on the visual page.
The new concept of the Container has the following effect on the existing concept of the Toast (See Toasts):
This ability is omitted since the container decides about the position of apperance.