Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test question page command forwarder (trunk) #4042

Conversation

nicoroeser
Copy link
Contributor

A dedicated command forwarder class in the test module is currently broken in all branches. This pull request fixes it.

See the commit message for details.

Mantis issue originally reported for version currently for version reproduced in 5.4 reproduced in 6 reproduced in 7 fixed for 5.4 fixed for 6 fixed for 7
Mantis#28489 5.4.12 7.5 ✓ yes ✓ yes ❌ no¹ ✓ yes ✓ yes N/A
Mantis#30982 7.2 7.2 N/A N/A ✓ yes N/A N/A ✓ yes
Mantis#31297 6.10 (also in 5.4.21) 6.10 (also in 5.4.21) ✓ yes ✓ yes ✓ yes ✓ yes ✓ yes ✓ yes

Can not test with ILIAS 8 (branch trunk) for the time being, because test creation fails, and test8 is down for maintenance.

N/A=not applicable (bug not present and/or functionality not present in that version)

¹ see Mantis#30982 for Mantis#28489~76854

Mantis#30411: HTML-Code in der der Antwortstatistik (see Mantis#30411~74982) is unrelated.

This is the pull request for the trunk branch. Please see the other pull requests for the other branches. Thanks.

When code was moved from the test GUI object in 27bebea, a
necessary adaption of the target class was missed (`$this` now points to
another class).

Fixes <https://mantis.ilias.de/view.php?id=28489#c76854>.
Fixes <https://mantis.ilias.de/view.php?id=30982>.
Fixes <https://mantis.ilias.de/view.php?id=31297>.
@dsstrassner dsstrassner added bugfix php Pull requests that update Php code labels Feb 15, 2022
@mbecker-databay
Copy link
Contributor

Thank you so much for this PR!

@mbecker-databay mbecker-databay merged commit 78fdfa2 into ILIAS-eLearning:trunk Feb 23, 2022
@nicoroeser nicoroeser deleted the fix-test-question-page-command-forwarder-trunk branch July 19, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants