Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue is no HTTP_COOKIE key is available in $_SERVER #4031

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix issue is no HTTP_COOKIE key is available in $_SERVER #4031

merged 1 commit into from
Feb 17, 2022

Conversation

pascalseeland
Copy link
Contributor

The $server["HTTP_COOKIE"] is not guaranteed to be available in PHP. On my system, this is not the case and fails the script.

@pascalseeland pascalseeland requested a review from klees February 11, 2022 22:13
@mjansenDatabay mjansenDatabay added bugfix php Pull requests that update Php code labels Feb 13, 2022
klees
klees approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@klees klees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@smeyer-ilias
Copy link
Contributor

Thanks, LGTM.
This is only a PHP8 issue, so no merge to older branches is required. If not please write a comment.

@smeyer-ilias smeyer-ilias merged commit c8fc429 into ILIAS-eLearning:trunk Feb 17, 2022
@pascalseeland pascalseeland deleted the fix-no-httpcookie-available branch February 17, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klees klees klees approved these changes

Assignees

@smeyer-ilias smeyer-ilias

Labels
bugfix php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalseeland @smeyer-ilias @klees @mjansenDatabay