Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TA: 21997, do not (auto)save over max passes. #4027

Merged
merged 1 commit into from
Feb 23, 2022
Merged

TA: 21997, do not (auto)save over max passes. #4027

merged 1 commit into from
Feb 23, 2022

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Feb 11, 2022

@mjansenDatabay mjansenDatabay added bugfix php Pull requests that update Php code labels Feb 11, 2022
@dsstrassner
Copy link
Contributor

I discussed the approach with @nhaagen and his fix covers both scenarios, which are provided in the mantis report by ctunjic and nils_brockmann. Thanks a lot @nhaagen.

@mbecker-databay
Copy link
Contributor

Thank you for tackling this one! I really appreciate it!

@mbecker-databay mbecker-databay merged commit f33952f into ILIAS-eLearning:release_7 Feb 23, 2022
mbecker-databay added a commit that referenced this pull request Feb 23, 2022
@mbecker-databay
Merge pull request #4027 from nhaagen/7/TA/21097
aafc25a 
TA: 21997, do not (auto)save over max passes.
mbecker-databay added a commit that referenced this pull request Feb 23, 2022
@mbecker-databay
Merge pull request #4027 from nhaagen/7/TA/21097
1c69702 
TA: 21997, do not (auto)save over max passes.
@nhaagen nhaagen deleted the 7/TA/21097 branch July 11, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbecker-databay mbecker-databay

@dsstrassner dsstrassner

Labels
bugfix php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nhaagen @dsstrassner @mbecker-databay @mjansenDatabay