Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Layout: Breadcrumbs in Content #3905

Merged
merged 3 commits into from
Feb 20, 2022

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Jan 14, 2022

This moves the breadcrumbs into the content-space of the main template.
Results look like this:
Screenshot from 2022-01-14 11-55-30
Screenshot from 2022-01-14 11-56-07

@matthiaskunkel
Copy link
Member

Does this change will remove the empty breadcrump row from screens where no tree-based content (like in Dashboard or Calendar) is shown as well?

@yvseiler
Copy link
Collaborator

yvseiler commented Feb 7, 2022

Does this change will remove the empty breadcrump row from screens where no tree-based content (like in Dashboard or Calendar) is shown as well?

With this PR only the position of the breadcrumb is changed for the moment. In case of an empty breadcrumb row, this has the advantage that it no longer takes the prominent place in the header (and there is a "gap" between header and mainbar), however, the empty breadcrumb row remains in the content area.

@matthiaskunkel
Copy link
Member

Jour Fixe, 07 FEB 2022 : We highly appreciate this suggestion and accept the PR for trunk. It would be great if empty breadcrumbs would be invisible.

@Amstutz
Copy link
Contributor

Amstutz commented Feb 8, 2022

@nhaagen , @klees : is it possible, to only render the breadcrumbs if there are entries? If not, Ill merge as is. If so, adding this along with a unit test making sure, empty breadcrumbs do not render would be great.

@nhaagen
Copy link
Contributor Author

nhaagen commented Feb 8, 2022

I'll have a look.

@nhaagen nhaagen force-pushed the _trunk/UI/PageLayout branch from dba3efd to 6800ae5 Compare February 8, 2022 11:10
@Amstutz Amstutz merged commit 10ed64f into ILIAS-eLearning:trunk Feb 20, 2022
@nhaagen nhaagen deleted the _trunk/UI/PageLayout branch July 11, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants