Notification System » Toasts » Notification Center #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iszmais
changed the title
Modules/Chatroom/GlobalScreen/ChatInvitationNotificationProvider.php
Outdated
Show resolved
Hide resolved
mjansenDatabay
requested changes
Feb 4, 2022
Modules/Chatroom/GlobalScreen/ChatInvitationNotificationProvider.php
Outdated
Show resolved
Hide resolved
Modules/Chatroom/GlobalScreen/ChatInvitationNotificationProvider.php
Outdated
Show resolved
Hide resolved
Services/Notifications/classes/Setup/ilNotificationUpdateSteps.php
Outdated
Show resolved
Hide resolved
mjansenDatabay
requested changes
Feb 8, 2022
There was a problem hiding this comment.
Hi @iszmais,
I added a few new remarks.
I guess the following issues are handled in a separate PR?
- Adding a
ROADMAP.md - Handling the client-side-only
ILIAS Page Editor Notificationsin the two files ofService/CoPage, which illegally used of the notification JS files
Services/Notifications/classes/Provider/NotificationMainBarProvider.php
Outdated
Show resolved
Hide resolved
mjansenDatabay
changed the title
Notification System -> Toasts -> Notification Center
mjansenDatabay
changed the title
Notification System -> Toasts -> Notification CenterNotification System » Toasts » Notification Center
iszmais
changed the title
Notification System » Toasts » Notification Center
|
Hi @Amstutz @matthiaskunkel , since the dependencies are merged, this is now ready for review and testing. (I did send you the acces data to the test installation per mail) Greetings, |
…async reloading of the NC
|
@Amstutz @matthiaskunkel both gave the approval for merge. Greetings, |
mjansenDatabay
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON #3671