-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language: add hook to sort entries in language files #3575
Language: add hook to sort entries in language files #3575
Conversation
Great @nhaagen ! Does this work on Windows machines? AFAIK @mbecker-databay still uses Windows for development ;-), and if he'd like to use the The question is: Do we care about developers using Windows :)? |
Well, I think we do care, since we are nice people and all ;), and I expect Windows to be of more relevance especially when it comes to translations. I'll find somebody to check into this. |
I verified with @catkrahl in both git-bash and power shell: it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move the script to the CI
folder. I don't have any other objections.
But I don't know if I am the only person who decides upon changes applied to the captainhook.json
. So maybe we should put this on a JF agenda and discuss this.
Thanks, @mjansenDatabay, for your review and reply. I have added this PR to the agenda of the upcoming JourFixe at Dec 13, 2021. |
Hey @mjansenDatabay, |
Jour Fixe, 13 DEC 2021 : We highly appreciate this suggestion and accept the PR for trunk and release 6 and 7. |
98c2635
to
e70fcf1
Compare
Hi @nhaagen, I am bit too late with reviewing this PR. Now it has conflicts. Sorry. Can you solve them? I really would appreciate to introduce the sorting of language files. |
fc8fb1a
to
fb8186d
Compare
fb8186d
to
a9669f5
Compare
Hi @matthiaskunkel , |
Thanks to @nhaagen for this PR. Accepted and merged to trunk. |
Following #3562 and a JF-vote for sorted lang-entries, here is my suggestion on a pre-commit hook.