Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language: add hook to sort entries in language files #3575

Merged

Conversation

nhaagen
Copy link
Contributor

@nhaagen nhaagen commented Aug 26, 2021

Following #3562 and a JF-vote for sorted lang-entries, here is my suggestion on a pre-commit hook.

@nhaagen nhaagen requested a review from mjansenDatabay August 26, 2021 09:54
@mjansenDatabay
Copy link
Contributor

mjansenDatabay commented Aug 26, 2021

Great @nhaagen !

Does this work on Windows machines? AFAIK @mbecker-databay still uses Windows for development ;-), and if he'd like to use the Caiptn, this will probably fail.

The question is: Do we care about developers using Windows :)?

@nhaagen
Copy link
Contributor Author

nhaagen commented Aug 26, 2021

Well, I think we do care, since we are nice people and all ;), and I expect Windows to be of more relevance especially when it comes to translations. I'll find somebody to check into this.

@nhaagen
Copy link
Contributor Author

nhaagen commented Aug 26, 2021

I verified with @catkrahl in both git-bash and power shell: it works.

Copy link
Contributor

@mjansenDatabay mjansenDatabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move the script to the CI folder. I don't have any other objections.

But I don't know if I am the only person who decides upon changes applied to the captainhook.json. So maybe we should put this on a JF agenda and discuss this.

@matthiaskunkel
Copy link
Member

Thanks, @mjansenDatabay, for your review and reply. I have added this PR to the agenda of the upcoming JourFixe at Dec 13, 2021.

@nhaagen
Copy link
Contributor Author

nhaagen commented Dec 1, 2021

Hey @mjansenDatabay,
I moved the script to CI, langfolder was awkward anyway.
Cheers

captainhook.json Outdated Show resolved Hide resolved
@matthiaskunkel
Copy link
Member

Jour Fixe, 13 DEC 2021 : We highly appreciate this suggestion and accept the PR for trunk and release 6 and 7.

@matthiaskunkel
Copy link
Member

Hi @nhaagen, I am bit too late with reviewing this PR. Now it has conflicts. Sorry. Can you solve them? I really would appreciate to introduce the sorting of language files.
Best, matthias

@nhaagen nhaagen force-pushed the _trunk/Language/preHook branch from fc8fb1a to fb8186d Compare March 15, 2022 08:40
@nhaagen nhaagen force-pushed the _trunk/Language/preHook branch from fb8186d to a9669f5 Compare March 15, 2022 08:48
@nhaagen
Copy link
Contributor Author

nhaagen commented Mar 15, 2022

Hi @matthiaskunkel ,
I resetted to trunk and applied sorting. HIt "merge" quickly :)
Cheers, Nils

@matthiaskunkel
Copy link
Member

Thanks to @nhaagen for this PR. Accepted and merged to trunk.

@matthiaskunkel matthiaskunkel merged commit 131b3f0 into ILIAS-eLearning:trunk Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants