WIP: GlobalScreen: Client-Side Notifications #2119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-side-notifications # Conflicts: # Services/GlobalScreen/artifacts/global_screen_providers.php # Services/GlobalScreen/classes/Setup/class.ilGlobalScreenBuildProviderMapObjective.php # Services/GlobalScreen/classes/class.ilGSProviderFactory.php # src/GlobalScreen/Collector/CollectorFactory.php # src/GlobalScreen/Provider/NullProviderFactory.php # src/GlobalScreen/Provider/ProviderFactory.php # src/GlobalScreen/Scope/Layout/Collector/MainLayoutCollector.php # src/GlobalScreen/Scope/Notification/README.md
… feature/6-0/plr-client-side-notifications # Conflicts: # src/GlobalScreen/Client/dist/GS.js # src/GlobalScreen/Client/src/GS.ts # src/GlobalScreen/Client/tsconfig.json # src/GlobalScreen/Scope/Layout/Collector/MainLayoutCollector.php
srgitlab
force-pushed
the
feature/6-0/plr-client-side-notifications
branch
from
f93a3fa to
417acf4
Compare
|
@mjansenDatabay this may get closed, isn't it? |
|
IMO, yes. |
|
@mjansenDatabay You really must learn, how to block notifications, when your are not in office :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #2099, this PR contains the extensions for client-side notifications (required by the chat in ILIAS 6).
Note: This is not a general approach how to do client-side rendering in ILIAS or even bypass it. This mechanism is implemented due to the missing client-side rendering for the requirements of chat notifications. The discussion about client-side rendering will be conducted separately and should provide a general approach.
This part of the GlobalScreen service also contains TypeScript code. Work is already underway on this in a wide variety of places. This suggestion here is not to bypass this by any means or to deliver final concepts for the use of TypeScript in ILIAS. TypeScript was only used here to have a more understandable and secure structure in JS. We are already looking forward to the discussions about TypeScript.
@mjansenDatabay will take over from here and implement the UseCases in the chat notifications.
This PR also contains all changes from #2099