UI: Strip Tags in New Input Implementation #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amstutz
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
Thx a lot @klees for this important addition. In future we might need a litte mutator to allow tags for some scenarios of those fields, where the client sanitizes the input in a more elaborate way.
However, I think it would be a better long term perspective to adapt such scenarios by using markup and do things like bold this way (as github does).
| @@ -427,6 +427,9 @@ private function getOperations() { | |||
| * @inheritdoc | |||
| */ | |||
| final public function getContent() { | |||
| if (is_null($this->content)) { | |||
| throw new \LogicException("No content of this field has been evaluated yet. Seems withInput was not called."); | |||
| } | |||
| @@ -45,7 +45,7 @@ public function withInput(PostData $input); | |||
| /** | |||
| * Get the current content of the input. | |||
| * | |||
| * @return Result|null | |||
| * @return Result | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing the issue of XSS-protection in the new input implementation of the UI-framework in #1189, @Amstutz and I decided to remove tags altogether in the currently available text-input-fields to allow people to use the new input implementation without the burden to think of correctly removing XSS-related input. This will break use-cases, where textarea and text field should actually be used to input HTML, but we prefer bug reports for these cases over XSS-vulnerabilities.
We will look into a proper long term solution for the use-cases that actually need some html-tags for ILIAS 6.0.
Note that this is no breaking change, thus no JF-decision etc. is required.