UI: More carefully select acceptable client side values in Select-Field #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a select is not required, also an empty string is a valid option.
chfsx
approved these changes
Oct 4, 2018
|
Wow, that was fast =) |
|
=) I did not run the tests (since Travis will do that) but isClientSideValueOk($value) seems right! I has something similar in the TagInput |
|
To me this is not an implicit change of the interface of this component. Your change is directly derived from the components definition, therefore we do not need any change of the description of the component and may merge directly. @klees do you agree? If so, ill merge. |
|
Yes, I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
Select Fieldallows the clients to pass a rather broad set of values (all strings). This is not correct, as only keys of known options will ever be retrieved from a benign client. This PR restricts the acceptable client values accordingly and tests the behaviour.