[FIX] UI: remove for attribute of Field\Section component (has no vis…

…ible form control).
ILIAS-eLearning · Sep 18, 2024 · e5df219 · e5df219
1 parent 4f67c74
commit e5df219
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/components/ILIAS/Test/tests/Scoring/Settings/ScoreSettingsTest.php b/components/ILIAS/Test/tests/Scoring/Settings/ScoreSettingsTest.php
@@ -216,7 +216,7 @@ public function testScoreSettingsSectionScoring(): void
             'test_scoring',
             $i1 . $i2 . $i3,
             null,
-            'id_4',
+            '',
             ''
         );
         $this->assertHTMLEquals($expected, $this->brutallyTrimSignals($actual));
@@ -367,7 +367,7 @@ public function testScoreSettingsSectionSummary(): void
             'test_results',
             $i1,
             null,
-            'id_8',
+            '',
             ''
         );
         $this->assertEquals($expected, $this->brutallyTrimSignals($actual));
@@ -416,7 +416,7 @@ public function testScoreSettingsSectionDetails(): void
             'tst_results_details_options',
             $options,
             null,
-            'id_8',
+            '',
             ''
         );
         $this->assertEquals($expected, $this->brutallyTrimSignals($actual));
@@ -494,7 +494,7 @@ public function testScoreSettingsSectionGamification(): void
             'tst_results_gamification',
             $group,
             null,
-            'id_10',
+            '',
             ''
         );
         $this->assertHTMLEquals($expected, $this->brutallyTrimSignals($actual));

diff --git a/components/ILIAS/UI/src/Implementation/Component/Input/Field/Renderer.php b/components/ILIAS/UI/src/Implementation/Component/Input/Field/Renderer.php
@@ -749,7 +749,7 @@ protected function renderSection(F\Section $section, RendererInterface $default_
             $inputs_html .= $default_renderer->render($input);
         }
         $id = $this->bindJavaScript($section) ?? $this->createId();
-        return $this->wrapInFormContext($section, $section->getLabel(), $inputs_html, $id);
+        return $this->wrapInFormContext($section, $section->getLabel(), $inputs_html, $id, '', false);
     }
 
     protected function renderUrlField(F\Url $component, RendererInterface $default_renderer): string

diff --git a/components/ILIAS/UI/tests/Component/Input/Field/SectionInputTest.php b/components/ILIAS/UI/tests/Component/Input/Field/SectionInputTest.php
@@ -67,7 +67,7 @@ public function testSectionRendering(): void
             $label,
             $f1 . $f2,
             $byline,
-            'id_3'
+            ''
         );
         $this->assertEquals($expected, $this->render($section));
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,7 +67,7 @@ public function testSectionRendering(): void @@
                 $label,
                 $f1 . $f2,
                 $byline,
-                'id_3'
+                ''
             );
             $this->assertEquals($expected, $this->render($section));
         }
@@ Expand Down @@