Course: fix icon size, saving with all disabled items in timing view …

…(43290, 43292)
ILIAS-eLearning · Dec 18, 2024 · b298c09 · b298c09
1 parent 3c306ea
commit b298c09
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/components/ILIAS/Course/classes/Timings/class.ilTimingsPersonalTableGUI.php b/components/ILIAS/Course/classes/Timings/class.ilTimingsPersonalTableGUI.php
@@ -20,6 +20,8 @@
 
 use ILIAS\Refinery\Factory as Refinery;
 use ILIAS\HTTP\Services as HTTPServices;
+use ILIAS\UI\Factory as UIFactory;
+use ILIAS\UI\Renderer as UIRenderer;
 
 /**
  * TableGUI class for editing personal timings
@@ -35,6 +37,8 @@ class ilTimingsPersonalTableGUI extends ilTable2GUI
 
     protected Refinery $refinery;
     protected HTTPServices $http;
+    protected UIFactory $ui_factory;
+    protected UIRenderer $ui_renderer;
 
     public function __construct(
         object $a_parent_class,
@@ -46,6 +50,8 @@ public function __construct(
 
         $this->http = $DIC->http();
         $this->refinery = $DIC->refinery();
+        $this->ui_factory = $DIC->ui()->factory();
+        $this->ui_renderer = $DIC->ui()->renderer();
 
         $this->container = $a_container_obj;
         $this->main_container = $a_main_container;
@@ -121,9 +127,13 @@ protected function fillRow(array $a_set): void
             $this->tpl->parseCurrentBlock();
         }
         if ($a_set['failure'] ?? false) {
+            $icon = $this->ui_factory->symbol()->icon()->custom(
+                ilUtil::getImagePath("standard/icon_alert.svg"),
+                $this->lng->txt("alert"),
+                'medium'
+            );
             $this->tpl->setCurrentBlock('alert');
-            $this->tpl->setVariable('IMG_ALERT', ilUtil::getImagePath("standard/icon_alert.svg"));
-            $this->tpl->setVariable('ALT_ALERT', $this->lng->txt("alert"));
+            $this->tpl->setVariable('IMG_ALERT', $this->ui_renderer->render($icon));
             $this->tpl->setVariable("TXT_ALERT", $this->lng->txt($a_set['failure']));
             $this->tpl->parseCurrentBlock();
         }

diff --git a/components/ILIAS/Course/classes/class.ilCourseContentGUI.php b/components/ILIAS/Course/classes/class.ilCourseContentGUI.php
@@ -312,7 +312,7 @@ protected function updatePersonalTimings(): bool
         $this->tabs->clearSubTabs();
         $failed = array();
 
-        $post_item = (array) ($this->http->request()->getParsedBody()['item']) ?? [];
+        $post_item = (array) ($this->http->request()->getParsedBody()['item'] ?? []);
         foreach ($post_item as $ref_id => $data) {
             $sug_start_dt = ilCalendarUtil::parseIncomingDate($data['sug_start']);
             $sug_end_dt = ilCalendarUtil::parseIncomingDate($data['sug_end']);

diff --git a/components/ILIAS/Course/templates/default/tpl.crs_personal_timings_row.html b/components/ILIAS/Course/templates/default/tpl.crs_personal_timings_row.html
@@ -10,7 +10,7 @@
 		<div class="il_Description" >{DESC}</div>
 		<!-- END item_description -->
 		<!-- BEGIN alert -->
-				<div class="help-block alert alert-danger" role="alert"><img border="0" src="{IMG_ALERT}" alt="{ALT_ALERT}" /> {TXT_ALERT}</div>
+				<div class="help-block alert alert-danger" role="alert">{IMG_ALERT} {TXT_ALERT}</div>
 		<!-- END alert -->
 		<!-- BEGIN tlt -->
 		<div class="il_ItemProperties">