Merge pull request #4594 from iszmais/bugfix/dashboard-visibility8

unified dashboard visibilities with common repository visibilities for ILIAS 8
ILIAS-eLearning · May 24, 2022 · 9d852fa · 9d852fa
2 parents 84a317d + bd33c51
commit 9d852fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Services/Dashboard/ItemsBlock/classes/class.ilPDSelectedItemsBlockMembershipsProvider.php b/Services/Dashboard/ItemsBlock/classes/class.ilPDSelectedItemsBlockMembershipsProvider.php
@@ -51,8 +51,7 @@ protected function getObjectsByMembership(array $objTypes = []) : array
             $parentTreeLftValue = $item->getParentLftTree();
             $parentTreeLftValue = sprintf("%010d", $parentTreeLftValue);
 
-            if (!$this->access->checkAccess('read', '', $refId) &&
-                !$this->access->checkAccess('visible', '', $refId)) {
+            if (!$this->access->checkAccess('visible', '', $refId)) {
                 continue;
             }
 

diff --git a/Services/Dashboard/ItemsBlock/classes/class.ilPDSelectedItemsBlockSelectedItemsProvider.php b/Services/Dashboard/ItemsBlock/classes/class.ilPDSelectedItemsBlockSelectedItemsProvider.php
@@ -36,7 +36,7 @@ public function getItems(array $object_type_white_list = array()) : array
         );
         $access_granted_favourites = [];
         foreach ($favourites as $idx => $favourite) {
-            if (!$this->access->checkAccess('read', '', $favourite['ref_id'])) {
+            if (!$this->access->checkAccess('visible', '', $favourite['ref_id'])) {
                 continue;
             }
             $access_granted_favourites[$idx] = $favourite;

diff --git a/Services/Repository/RecommendedContent/classes/class.ilDashboardRecommendedContentGUI.php b/Services/Repository/RecommendedContent/classes/class.ilDashboardRecommendedContentGUI.php
@@ -102,6 +102,9 @@ protected function getListItemGroups() : array
 
         foreach ($this->recommendations as $ref_id) {
             try {
+                if (!$DIC->access()->checkAccess('visible', '', $ref_id)) {
+                    continue;
+                }
                 $list_items[] = $this->getListItemForData($ref_id);
             } catch (ilException $e) {
                 continue;