harden 'template_values' column handling in certificate id migration

ILIAS-eLearning · Oct 23, 2024 · 88229ca · 88229ca
1 parent 42eec46
commit 88229ca
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/components/ILIAS/Certificate/classes/Setup/Migration/CertificateIdMigration.php b/components/ILIAS/Certificate/classes/Setup/Migration/CertificateIdMigration.php
@@ -82,8 +82,17 @@ public function step(Environment $environment): void
             'SELECT id, template_values FROM il_cert_user_cert WHERE certificate_id IS NULL'
         );
 
-        while($row = $this->db->fetchAssoc($result)) {
-            $template_values = json_decode($row['template_values'], true, 512, JSON_THROW_ON_ERROR);
+        while ($row = $this->db->fetchAssoc($result)) {
+            try {
+                $template_values = json_decode(
+                    $row['template_values'] ?? json_encode([], JSON_THROW_ON_ERROR),
+                    true,
+                    512,
+                    JSON_THROW_ON_ERROR
+                );
+            } catch (JsonException) {
+                $template_values = [];
+            }
             $certificate_id = $this->uuid_factory->uuid4AsString();
 
             $template_values['CERTIFICATE_ID'] = $certificate_id;