Skip to content

Commit

Permalink
Abandon System Style implementation (#8241)
Browse files Browse the repository at this point in the history
  • Loading branch information
Amstutz authored Oct 22, 2024
1 parent 42cae32 commit 53e0108
Show file tree
Hide file tree
Showing 50 changed files with 143 additions and 6,622 deletions.
17 changes: 1 addition & 16 deletions components/ILIAS/Style/System/ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,7 @@
and document the public interface. Especially refactor/get rid of the singleton pattern
for ilStyleDefinition and ilSystemStyleSettings
* Unit Test the public interface.

##Medium Prio
* Further replace legacy ui components with UI Components, namely:
* Settings Form
* Table in the Overview (Data Table needed)
* Creation dialogs (Some accordion like structure needed)
* Inputs with Coler for Icons (Color Input needed)
* Toolbar (Toolbar needed)
* Code Preview in Examples (Component to show text as code needed)
* Further extend testing coverage for GUI classes (usage of UI componentes needed)
* Improve DIC handling. Currently this is all handled through constructors, making constructors large.
maybe introduce a local DIC container, as done in study programe.

##Low Prio
* Introduce the File System Service for file access for this component. Note that for
this, a new Kontext (templates) ist needed for the file system service.
* Replace Legacy Table with Data Table in Overview



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,6 @@ public function executeCommand(): void
$cmd = $this->ctrl->getCmd() ? $this->ctrl->getCmd() : 'edit';
$style = $this->style_container->getSkin()->getStyle($this->style_id);

if ($style->isSubstyle()) {
if ($cmd == 'edit' || $cmd == 'view') {
$this->setSubStyleSubTabs('edit');
} else {
$this->setSubStyleSubTabs('assignStyle');
}
}

$assign_gui = new ilSubStyleAssignmentGUI(
$this,
$this->ctrl,
Expand Down Expand Up @@ -128,22 +120,6 @@ public function executeCommand(): void
}
}

protected function setSubStyleSubTabs(string $active = ''): void
{
$this->tabs->addSubTab(
'edit',
$this->lng->txt('settings'),
$this->ctrl->getLinkTargetByClass('ilsystemstyleconfiggui')
);
$this->tabs->addSubTab(
'assignStyle',
$this->lng->txt('assignment'),
$this->ctrl->getLinkTargetByClass('ilsystemstyleconfiggui', 'assignStyle')
);

$this->tabs->activateSubTab($active);
}

protected function edit(): void
{
$form = $this->editSystemStyleForm();
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 53e0108

Please sign in to comment.