Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checkout full history for formatting #668

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

johanneskoester
Copy link
Collaborator

@johanneskoester johanneskoester commented Oct 11, 2024

Description

Related Issue

Checklist

@huzuner
Copy link
Contributor

huzuner commented Oct 11, 2024

Conda command is not being found in some technology tests and in one benchmark test Could this also be about the recent conda change on snakemake?

@johanneskoester
Copy link
Collaborator Author

@alethomas unexpected failures here. Seems like a bug in pangolin's internal usage of the snakemake api.

@johanneskoester
Copy link
Collaborator Author

Ok, I think I found the problem. Seems to be fixed in the latest pangolin release.

@johanneskoester
Copy link
Collaborator Author

However, this is not yet merged: bioconda/bioconda-recipes#42192

@huzuner
Copy link
Contributor

huzuner commented Oct 16, 2024

curl: (28) Failed to connect to eutils.ncbi.nlm.nih.gov port 443 after 20000 ms: Timeout was reached I guess there were some connections issues there. Could you perhaps rerun the tests?

@huzuner
Copy link
Contributor

huzuner commented Oct 16, 2024

And for the ModuleNotFoundError: No module named 'distutils' error, I guess spades should be updated as discussed here: ablab/spades#1266

@alethomas
Copy link
Collaborator

I already made a PR for the spades update but I guess in order to get this one working I need to merge it

@huzuner
Copy link
Contributor

huzuner commented Oct 17, 2024

One of the technology tests is failing with:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

This also seems to be present in the master branch.
Could that be because of using the same path in Upload logs for both benchmark and technology tests:

path: .tests/logs/
and
path: .tests/logs/

@alethomas alethomas merged commit b8c5c44 into master Oct 17, 2024
26 checks passed
@alethomas alethomas deleted the johanneskoester-patch-1 branch October 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants