fix: fixed include flag KeyError #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasbtf
reviewed
Jan 19, 2022
workflow/rules/common.smk
Outdated
Comment on lines
1289
to
1290
| else: | ||
| continue |
There was a problem hiding this comment.
I`m not sure if this is needed 🤔
thomasbtf
approved these changes
Jan 19, 2022
alethomas
reviewed
Jan 19, 2022
workflow/rules/common.smk
Outdated
Comment on lines
1289
to
1290
| else: | ||
| continue |
There was a problem hiding this comment.
Suggested change
| else: | |
| continue |
There was a problem hiding this comment.
I'd also vote for leaving it out. If it's needed, we will see it 😉
alethomas
requested changes
Jan 19, 2022
workflow/rules/common.smk
Outdated
Comment on lines
1289
to
1290
| else: | ||
| continue |
There was a problem hiding this comment.
I'd also vote for leaving it out. If it's needed, we will see it 😉
alethomas
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem with the include_flag in common.smk. The get_assemblies_for_submission function gives the path to the faster file, not the name, leading to a KeyError in get_include_flag. This causes the inclusion of files in the high-quality-genomes, that should be excluded. Problem fixed by changing the functions used in get_include_flag_for_date and taking into account the lengths of the lists from get_assemblies_for_submission and get_sample_for_date.Related Issue
Checklist
pre-commitif needed.CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.