-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rule and script bed_to_bedpe #447
Conversation
Nice work 👍 I think we should place the ARTIC V3 default prime bed file in the resources and make it adjustable via the config. So anybody can adjust the primer scheme given to the workflow. What do you think? |
So you mean that in the config there should be the path to the bed file? And should the path to the bedpe file stay in the config? |
The path to the |
Looks good to me. @alethomas, what do you think about this? Folker wants us to look more closely at the PR and changes to the code. |
Maybe the docs should be updated and explain how to use a custom primer file. Best placement would be probably here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to include the bed file in our repo and not making the workflow downloading it? As it's not our primer set I'd prefer that
That is actually a good idea. However, then we have to think about handling "local" primer files via then config. It could be the case, that doesn't want to use the ARTIC primers or primer files, that are only downloadable via a URL. Maybe add a function that checks if the entry in the config is a URL or a path. Upon this check, the file is either downloaded or locally found. What do you think? |
@alethomas, @AKBrueggemann: What do you think? |
I really like this idea, @AKBrueggemann ? |
Alright, I'll change it, it is a good idea :) |
@alethomas Could you please also review? :) |
Description
A rule and a script for converting a .bed file containing information about the primer into a .bedpe file. The .bedpe file format is used in the workflow.Related Issue
#381Checklist
pre-commit
if needed.CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.