Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rule and script bed_to_bedpe #447

Merged
merged 11 commits into from
Feb 2, 2022
Merged

feat: rule and script bed_to_bedpe #447

merged 11 commits into from
Feb 2, 2022

Conversation

AKBrueggemann
Copy link
Collaborator

Description

A rule and a script for converting a .bed file containing information about the primer into a .bedpe file. The .bedpe file format is used in the workflow.

Related Issue

#381

Checklist

@AKBrueggemann AKBrueggemann linked an issue Jan 11, 2022 that may be closed by this pull request
@thomasbtf
Copy link
Contributor

Nice work 👍 I think we should place the ARTIC V3 default prime bed file in the resources and make it adjustable via the config. So anybody can adjust the primer scheme given to the workflow. What do you think?

@AKBrueggemann
Copy link
Collaborator Author

So you mean that in the config there should be the path to the bed file? And should the path to the bedpe file stay in the config?

@thomasbtf
Copy link
Contributor

The path to the .bed file in the config is probably enough because the workflow will generate the .bedpe.

@thomasbtf
Copy link
Contributor

Looks good to me. @alethomas, what do you think about this? Folker wants us to look more closely at the PR and changes to the code.

@thomasbtf
Copy link
Contributor

Maybe the docs should be updated and explain how to use a custom primer file. Best placement would be probably here.

@thomasbtf thomasbtf mentioned this pull request Jan 18, 2022
5 tasks
Copy link
Collaborator

@alethomas alethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to include the bed file in our repo and not making the workflow downloading it? As it's not our primer set I'd prefer that

@thomasbtf
Copy link
Contributor

That is actually a good idea. However, then we have to think about handling "local" primer files via then config. It could be the case, that doesn't want to use the ARTIC primers or primer files, that are only downloadable via a URL.

Maybe add a function that checks if the entry in the config is a URL or a path. Upon this check, the file is either downloaded or locally found.

What do you think?

@thomasbtf
Copy link
Contributor

@alethomas, @AKBrueggemann: What do you think?

@alethomas
Copy link
Collaborator

I really like this idea, @AKBrueggemann ?

@AKBrueggemann
Copy link
Collaborator Author

Alright, I'll change it, it is a good idea :)

@thomasbtf
Copy link
Contributor

@alethomas Could you please also review? :)

@thomasbtf thomasbtf merged commit 3022eab into master Feb 2, 2022
@thomasbtf thomasbtf deleted the bed-to-bedpe-file branch February 2, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a rule for converting bed to bedpe files
3 participants