Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: voc probability #541

Merged
merged 4 commits into from
Jun 18, 2022
Merged

fix: voc probability #541

merged 4 commits into from
Jun 18, 2022

Conversation

alethomas
Copy link
Collaborator

Description

with using the product of probabilities the overall probability of events was artificially increased. Therefore the calculation was switched to the minimum. Furthermore the Color scale in the final output was adjusted

Related Issue

Checklist

@alethomas alethomas changed the title Fix: voc probability fix: voc probability Jun 7, 2022
@alethomas alethomas requested a review from johanneskoester June 7, 2022 15:59
@alethomas alethomas merged commit db6eb17 into master Jun 18, 2022
@alethomas alethomas deleted the fix-voc-probability branch June 18, 2022 15:37
lenakinzel added a commit that referenced this pull request Jul 13, 2022
* chore(deps): bump pre-commit/action from 2.0.3 to 3.0.0 (#542)

Bumps [pre-commit/action](https://github.com/pre-commit/action) from 2.0.3 to 3.0.0.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v2.0.3...v3.0.0)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: voc probability (#541)

* fix: Replace outdated df append (#544)

* replaced all df.append with pd.concat

* replaced df.append with pd.concat

* replace df.append with pd.concat

* replaced df.append with pd.concat

* replaced df.append with pd.concat

* replaced df.append with pd.concat

Co-authored-by: lenakinzel <[email protected]>
Co-authored-by: Alexander Thomas <[email protected]>

* refactor: fgbio read clipping (#545)

* change primer file formatting

* change read clipping

* fmt

* fix primer clipping plot

* fix primer clipping plot

* fix

* fix

* typo

* test

* Update pangolin to 4.1 (#546)

Co-authored-by: thomasbtf <[email protected]>
Co-authored-by: Ann-Kathrin Brüggemann <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Thomas <[email protected]>
Co-authored-by: vBassewitz <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: thomasbtf <[email protected]>
Co-authored-by: Ann-Kathrin Brüggemann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants