Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregation of sample in variants and lineages over time plot #339

Closed
thomasbtf opened this issue Nov 28, 2021 · 1 comment · Fixed by #382
Closed

Fix aggregation of sample in variants and lineages over time plot #339

thomasbtf opened this issue Nov 28, 2021 · 1 comment · Fixed by #382
Assignees
@AKBrueggemann
Labels
bug Something isn't working

Comments

@thomasbtf
Copy link
Contributor

Currently lineages (https://github.com/IKIM-Essen/uncovar/blob/master/workflow/scripts/plot-lineages-over-time.py#L33) and variants (https://github.com/IKIM-Essen/uncovar/blob/master/workflow/scripts/plot-variants-over-time.py#L86) below a certain fixed, absolute threshold (10 occurrences) and masked and aggregated together.

This results in non-expressive figures, e.g.
image

Change this absolute threshold, e.g. to a relative one. However, feel free to think about how this problem can be solved without any threshold.
@thomasbtf thomasbtf added the bug Something isn't working label Dec 2, 2021
@AKBrueggemann AKBrueggemann linked a pull request Dec 8, 2021 that will close this issue
fix: relative aggregation of samples for variants and lineages over time plots #382
Merged
5 tasks
@AKBrueggemann AKBrueggemann mentioned this issue Dec 8, 2021
Merged
5 tasks
@thomasbtf
Copy link
Contributor Author

thomasbtf commented Dec 10, 2021 •
edited
Loading

There still seem to be a problem.

@AKBrueggemann Could you please revisit this?

From the run of 2021-12-10:
image

@thomasbtf thomasbtf reopened this Dec 15, 2021
@AKBrueggemann AKBrueggemann mentioned this issue Dec 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AKBrueggemann AKBrueggemann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: relative aggregation of samples for variants and lineages over time plots IKIM-Essen/uncovar
3 participants
@thomasbtf @alethomas @AKBrueggemann