Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gpameter.user.js #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ujjwalpawar
Copy link

Added option of satisfactory grade introduced for the fall semester of 2020. It's similar to the Pass/No Pass (P/NP) grade present in many universities.

Added option of satisfactory grade introduced for the fall semester of 2020. It's similar to the Pass/No Pass (P/NP)  grade present in many universities.
@SaiHarshaK
Copy link
Contributor

Your PR breaks the functionality of the script.
The thing you have mentioned regarding Pass/No Pass (P/NP) grade is for audit courses that aren't required to be kept track of anyway. Moreover, you cannot generalize it by just checking S grade, because during the pandemic students were given a choice between S and letter grade. Your change would count these credits as "satisfactory" instead of the appropriate ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants