Fix logic for getting values from LabelValuePair #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a faulty heuristic introduced in IIIF-Commons#60, which would override the default locale with the locale of the first label and then attempt to fetch the value with that logic. This heuristic breaks even in the simple case were labels are available in multiple languages, but the values only available in one. If the first language of the labels did not correspond to the language of the value, the client would get no value back. This is clearly in violation of the algorithm prescribed for IIIF property values in the Presentation API spec[1], which states: > If none of the values have a language associated with them, the client > must display all of the values. and > If all of the values have a language associated with them, and none > match the language preference, the client must select a language and > display all of the values associated with that language. as well as > If some of the values have a language associated with them, but none > match the language preference, the client must display all of the values > that do not have a language associated with them. [1] https://iiif.io/api/presentation/2.1/#language-of-property-values
|
This has been superseded by #75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a faulty heuristic introduced in #60, which would override the default locale with the locale of the first label and then attempt to fetch the value with that logic.
This heuristic breaks e.g. in the simple case were labels are available in multiple languages, but the values only available in one. If the first language of the labels did not correspond to the language of the value, the client would get no value back.
This is clearly in violation of the algorithm prescribed for IIIF property values in the Presentation API spec, which states:
and
as well as